feat: WIP: Ruby Logger instrumentation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
changed the title
kaylareopelle
commented
Mar 29, 2024
…-ruby-contrib into logger-instrumentation
…elle/opentelemetry-ruby-contrib into logger-instrumentation
Appraisal can't install gems from a git source. Since the appraisal is only necessary for active_support_logger, disable those tests while working on other features.
kaylareopelle
changed the title
chore: Allow logger patch tests to run
…-ruby-contrib into logger-instrumentation
…elle/opentelemetry-ruby-contrib into logger-instrumentation
feat: map logger level to OTel level
…ntelemetry-ruby-contrib into logger-instrumentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| ## Examples | ||
|
|
||
| Example usage can be seen in the `./example/logger.rb` file [here](https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/instrumentation/logger/example/logger.rb) |
There was a problem hiding this comment.
🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/instrumentation/logger/example/logger.rb Status: 404
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
…#1709) Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.2 to 2.4.3. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@05b42c6...4eaacf0) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-version: 2.4.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kayla Reopelle <[email protected]>
… Targets Poller Logic (open-telemetry#1536) * Add Rate Limiter and Sampling Targets Poller Logic * fix test cases related to rate limiter and timecop usage * add example for x-ray sampling on rails * address comments * address comments --------- Co-authored-by: Kayla Reopelle <[email protected]>
* refactor: unify rack middleware_args Ensure rack middleware_args are selected consistently based on `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable. * use only middleware_args in sinatra tests --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Kayla Reopelle <[email protected]>
feat: Enhance README Document configuration options for ActiveJob instrumentation. Co-authored-by: Kayla Reopelle <[email protected]> Co-authored-by: Ariel Valentin <[email protected]>
The gemspecs dependencies are currently not being updated automatically by dependabot. This change uses recursive directories instead of only updating the root Gemfile. https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/controlling-dependencies-updated#defining-multiple-locations-for-manifest-files
* revert: Fix dependabot syntax error (open-telemetry#1719) This reverts commit 60a630c. * revert: Configure Dependabot to update recursively (open-telemetry#1718) This reverts commit 2db52ff.
* opentelemetry-instrumentation-action_pack 0.14.1 (was 0.14.0) * opentelemetry-instrumentation-active_job 0.9.2 (was 0.9.1) * opentelemetry-instrumentation-rack 0.28.2 (was 0.28.1) * opentelemetry-instrumentation-sinatra 0.27.1 (was 0.27.0) Co-authored-by: otelbot <[email protected]>
* raise min tested Rails version * use constants for Ruby version and post-install message * update internal dep versions for consistency
* Add files for sql-processor gem * fix: filename change * Update helpers/sql-processor/CHANGELOG.md * Add gem to build matrix and release config --------- Co-authored-by: Kayla Reopelle <[email protected]>
* feat!: deprecate gem * Update message * Only one heading for README * Feedback updates * Revert version * Update helpers/sql-obfuscation/CHANGELOG.md Co-authored-by: Kayla Reopelle <[email protected]> * Update readme * Update helpers/sql-obfuscation/README.md * Update gemspec description --------- Co-authored-by: Kayla Reopelle <[email protected]>
Fix spacing for releases.yml file to release opentelemetry-helpers-sql-processor
* release: Release 2 gems * opentelemetry-helpers-sql-obfuscation 0.4.0 (was 0.3.0) * opentelemetry-helpers-sql-processor 0.1.0 (initial release) * chore: Update entry for deprecation notice --------- Co-authored-by: otelbot <[email protected]> Co-authored-by: Kayla Reopelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the Logs SDK implementation pending review in kaylareopelle/opentelemetry-ruby#6 to instrument Ruby's Logger class.
It also includes a workaround to prevent broadcasted logs in Rails < 7.1 from creating duplicate log records.
Co-Authored by: @khushijain21